ESQL: Fix double release in inline stats when LocalRelation is reused
#136467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace `LocalSupplier.of` with new `CopyingLocalSupplier` in `PruneColumns` - Add `INLINE_STATS_AFTER_PRUNED_AGGREGATE` capability - Add test cases for inline stats after aggregate pruning
elasticsearchmachine
added
needs:triage
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
elasticsearchmachine
removed
the
needs:triage
kanoshiou
changed the title
LocalRelation is reused
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The root cause was that when aggregate columns are pruned and no grouping columns exist, the optimizer creates a
LocalRelationwith aConstantNullBlockpage usingLocalSupplier.of()(which delegates toImmediateLocalSupplier), but during inline stats execution, this same page gets referenced and released twice - once when theLocalRelationserves as a source for the left-hand side of theInlineJoin, and again when it continues execution on the right-hand side, causing a double release error and connection closure. TheCopyingLocalSupplierprevents this by creating a deep copy of the page on eachget()call, ensuring proper memory management when the sameLocalRelationis used multiple times in inline stats scenarios.Same issue here as in
PropagateEmptyRelationandReplaceStatsFilteredAggWithEval. Maybe we could useCopyingLocalSupplieronly when theLocalRelationis under an inline stats plan and used on the right side — otherwise, stick withImmediateLocalSupplier.CopyingLocalSupplierdoes a deep copy, so it could hurt performance.Closes #135679